1. 17 Mar, 2022 2 commits
  2. 13 Mar, 2022 1 commit
  3. 16 Jan, 2022 1 commit
  4. 14 Dec, 2021 1 commit
    • Oliver Smith's avatar
      treewide: remove FSF address · 0c832fe7
      Oliver Smith authored
      Remove the paragraph about writing to the Free Software Foundation's
      mailing address. The FSF has changed addresses in the past, and may do
      so again. In 2021 this is not useful, let's rather have a bit less
      boilerplate at the start of source files.
      
      Change-Id: I2e98f89f6738d03c45a2106820af0912692093f3
      0c832fe7
  5. 09 Dec, 2021 7 commits
  6. 08 Dec, 2021 9 commits
    • Harald Welte's avatar
      switch to libosmocore multihread-logging · a9d7ad11
      Harald Welte authored
      When osmo-remsim was originally developed, libosmocore logging was
      not yet thread-safe.  This meant that the worker threads of remsim-bankd
      and remsim-server could not log via the libosmocore logging framework
      but directly used stderr/stdout, which produced rather inconsistent log
      output.
      
      However, since 1.3.0, libosmocore has received support for
      multi-threaded applications.  Let's make use of this and consistently
      use it in remsim-server and remsim-bankd.  This obviously also means
      adding some more log categories.
      
      Change-Id: I7bd5264c559b756927046563a2d00c54826bee9b
      a9d7ad11
    • Harald Welte's avatar
      Add separate log category for RSPRO protocol · 46122ab9
      Harald Welte authored
      Change-Id: I2e158f5181a24ae2256aae12d26865c4907eabad
      46122ab9
    • Harald Welte's avatar
      logging: Print category + level, disable category-hex · 73bbd54c
      Harald Welte authored
      Change-Id: I9ae27b78b965d173146583b030fd93e2d70b845e
      73bbd54c
    • Harald Welte's avatar
      [cosmetic] bankd: mark handle_options() as static · f8c6eeb5
      Harald Welte authored
      Change-Id: I991542d8fb52cc86e850bf5d20352c802f77c392
      f8c6eeb5
    • Harald Welte's avatar
      Change default log level to INFO · 0c7f7d45
      Harald Welte authored
      this will drop printing DEBUG level messages by default.
      
      Change-Id: I8ecb17674d480988847d7fa23b586b66fa52010a
      0c7f7d45
    • Harald Welte's avatar
      rspro_client_fsm: Differentiate different log levels · 8934412c
      Harald Welte authored
      Raw Rx/Tx of messages should be LOGL_DEBUG, while connection
      establishment/loss should be something like LOGL_NOTICE.
      
      Change-Id: I1bc6d491a8a748cbd729cbdeede60d32bd760a15
      8934412c
    • Harald Welte's avatar
      bankd_pcsc: Don't log every successful SCardTransmit · 50a0972a
      Harald Welte authored
      Contrary to other operations, SCardTransmit has a much higher frequency
      and the logs should not be clobbered with "OK" lines all over the place.
      
      Change-Id: Icf87b61d71722b2998ae78f9aee7c4ad94c46da7
      50a0972a
    • Harald Welte's avatar
      bankd_main: Improve log usefulness · 9f7ca61b
      Harald Welte authored
      Right now we get duplicate log lines like
      
      [000 CONN_CLIENT_MAPPED_CARD] bankd_main.c:662 Rx RSPRO tpduModemToCard
      [000 CONN_CLIENT_MAPPED_CARD] bankd_main.c:623 tpduModemToCard(0070000001)
      
      Where the first line is printed by the generic receive handler for RSPRO
      messages, while the second line is from the specific handler function
      handling the specific message type.
      
      Let's only print from the generic message handler if no specific
      handler function exists.
      
      Change-Id: I992c847e0081bd1cd8a0b70212618c4980d9db81
      9f7ca61b
    • Harald Welte's avatar
      bankd_pcsc: Improve logging in non-error case · 168d7247
      Harald Welte authored
      Before this commit, the PCSC operation (e.g. SCardStatus) is only
      printed in the error case, but not in the debug case.  Let's fix that.
      
      [000 CONN_CLIENT_MAPPED_CARD] bankd_pcsc.c:196 : OK
      
      	will become
      
      [000 CONN_CLIENT_MAPPED_CARD] bankd_pcsc.c:196 SCardTransmit: OK
      
      Change-Id: I3c77655c5d1f76be778cb8873d8acf1343c87b05
      168d7247
  7. 08 Sep, 2021 1 commit
    • Harald Welte's avatar
      client: request card-remove and sim-local when no bankd/slot is set · 7b87ba1e
      Harald Welte authored
      When the client leaves the OPERATIONAL state, do the inverse of what
      happens when entering that state:
      * request "card insert" no longer to be generated towards modem
      * request switch back to local SIM
      * reset the modem to notice the change
      
      This way entering remote-sim operation due to adding a slotmap
      and leaving remote-sim due to removing the slotmap should be
      symmetrical.
      
      Change-Id: Ifaa4b60474bf8585bfbe0288062f581821bd3faa
      Closes: OS#5216
      7b87ba1e
  8. 01 Sep, 2021 1 commit
  9. 23 Jun, 2021 2 commits
    • Oliver Smith's avatar
      contrib/osmo-remsim.spec.in: fix build on opensuse · 694e3b57
      Oliver Smith authored
      It was not enough to verify that the rpm builds on centos.
      
      Set --docdir to install examples to /usr/share/doc/packages instead of
      /usr/share/doc in opensuse. Fix for:
        File not found: .../usr/share/doc/packages/osmo-remsim/examples/bankd_pcsc_slots.csv
      
      Add missing %dir statements to fix:
        osmo-remsim-bankd-0.2.2.113.f2a1.202106230026-lp151.1.1.x86_64.rpm: directories not owned by a package:
         - /etc/osmocom
         - /usr/share/doc/packages/osmo-remsim
         - /usr/share/doc/packages/osmo-remsim/examples
      
      Fixes: 905bc4d2 ("doc/examples: install bankd_pcsc_slots.csv")
      Change-Id: Ie5bbb25f8aa87edcea8b952d3c29aab29ac31b19
      694e3b57
    • Oliver Smith's avatar
      distro packaging: fix missing path for example · 588ec1a6
      Oliver Smith authored
      The boilerplate code for installing configs used in other Osmocom
      projects doesn't only install the example configs to /etc/osmocom, but
      also to /usr/share/doc/. Add the missing path.
      
      Fixes: 905bc4d2 ("doc/examples: install bankd_pcsc_slots.csv")
      Change-Id: I95e4aa34d54bb485ff7ebb5e44d9c1db92ad8fe0
      588ec1a6
  10. 22 Jun, 2021 3 commits
  11. 19 Feb, 2021 1 commit
  12. 03 Feb, 2021 1 commit
    • Harald Welte's avatar
      bankd: regex matching of reader names · 753c8aa8
      Harald Welte authored
      So far, bankd did a 1:1 string match of the CSV file line against
      the reader name.  As pcsc-lite reader names unfortunately tend to
      change at times, we introduce matching by regular expressions in
      this patch.
      
      Change-Id: I58b71f9562e152e7ed21b55d7b876bba481b01f8
      753c8aa8
  13. 28 Jan, 2021 1 commit
  14. 13 Jan, 2021 1 commit
  15. 20 Oct, 2020 1 commit
  16. 18 Oct, 2020 1 commit
  17. 19 Jul, 2020 1 commit
  18. 22 Jun, 2020 1 commit
  19. 28 May, 2020 1 commit
  20. 25 May, 2020 3 commits