ath10k-firmware Makefile references non-existent QCA9887_BOARD_FILE_MD5 and QCA9887_FIRMWARE_FILE_MD
Username: Hannu Nyman
Origin: https://bugs.openwrt.org/index.php?do=details&task_id=341
I noticed today a strangely named downloaded file “board.bin.” in /dl after an update, and that made me to investigate a bit.
The commit “treewide: clean up download hashes” eliminated all MD5 hashes from the core Makefiles and replaced the _MD5 hash definitions with _HASH definitions:
But at least two instances of filenames in ath10k-firmware Makefile were left with references to the deleted _MD5 definition, which leads to hash being absent from the filename.
The block with the wrong references is:
QCA9887_FIRMWARE_FILE:=firmware-5.bin_10.2.4-1.0-00013
QCA9887_FIRMWARE_FILE_HASH:=5966408bd41f309edb595344b8dd088c0fed212debfd91e5f3e8a55ea119c16d
QCA9887_FIRMWARE_FILE_DL:=(QCA9887_FIRMWARE_FILE).
(QCA9887_FIRMWARE_FILE_MD5)
QCA9887_BOARD_FILE:=board.bin
QCA9887_BOARD_FILE_HASH:=cf4df099f6ee05c181f55ce17297a1d32c61d725eb96246fd315ad5587c42426
QCA9887_BOARD_FILE_DL:=(QCA9887_BOARD_FILE).
(QCA9887_BOARD_FILE_MD5)
Both filenames are intended to include the hash, but due to the wrong variable, hash gets left out.
I am not sure if that causes any actual damage right now, but at least the file name is not like it is intended to be.